Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for readme and demo ipynb and a small update for deprecated function #360

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Updates for readme and demo ipynb and a small update for deprecated function #360

merged 1 commit into from
Apr 18, 2024

Conversation

ker2xu
Copy link
Contributor

@ker2xu ker2xu commented Apr 17, 2024

  1. Add scikit-learn to requirements; 2. Update deprecated function of peft; 3. set CUDA_VISIBLE_DEVICES=0 in ppo part of demo ipynb such that users with multi CUDA devices can run it smoothly; 4; Modify the test step in demo ipynb to non-interactive; 5. Copy INSTALL step to ENG doc.

@ker2xu
1. Add scikit-learn to requirements; 2. Update deprecated API of peft…
0307794 
…; 3. set CUDA_VISIBLE_DEVICES=0 in ppo part of demo ipynb such that users with multi CUDA devices can run it smoothly; 4; Modify the test step in demo ipynb to non-interactive; 5. Copy INSTALL step to ENG doc.
shibing624
shibing624 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Owner

@shibing624 shibing624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@shibing624 shibing624 merged commit 3b604e5 into shibing624:main Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibing624 shibing624 shibing624 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ker2xu @shibing624